Skip to content

Fix missing SegmentDescription in PydicomReader - #6937

Merged
wyli merged 11 commits into
Project-MONAI:devfrom
KumoLiu:pydicomreader
Sep 4, 2023
Merged

wyli merged 11 commits into
Project-MONAI:devfrom
KumoLiu:pydicomreader

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Fixes #6928.

Description

SegmentDescription is optional, https://dicom.innolitics.com/ciods/segmentation/segmentation-image/00620002/00620006, so try SegmentLabel first.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Comment thread monai/data/image_reader.py Outdated
@wyli

wyli commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) September 4, 2023 12:03
Comment thread monai/data/image_reader.py Outdated
@wyli
wyli disabled auto-merge September 4, 2023 13:01
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wyli

wyli commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) September 4, 2023 13:34
@Nic-Ma
Nic-Ma requested a review from binliunls September 4, 2023 14:19
@wyli
wyli merged commit d876c3f into Project-MONAI:dev Sep 4, 2023
@KumoLiu
KumoLiu deleted the pydicomreader branch September 5, 2023 02:35
@wyli wyli mentioned this pull request Sep 5, 2023
1 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get an error when reading dicom segmentation

4 participants